Skip to content
This repository was archived by the owner on Nov 12, 2025. It is now read-only.

test: test on Python 3.9 - #99

Merged
tswast merged 10 commits into
masterfrom
autosynth-synthtool
Jan 11, 2021
Merged

test: test on Python 3.9#99
tswast merged 10 commits into
masterfrom
autosynth-synthtool

Conversation

@yoshi-automation

Copy link
Copy Markdown
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/6f0f288a-a1e8-4b2d-a85f-00b1c6150185/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@9a7d9fb

 autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
* docs(python): update intersphinx for grpc and auth
* use https for python intersphinx
Co-authored-by: Tim Swast <swast@google.com>
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Nov 18 14:37:25 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 9a7d9fbb7045c34c9d3d22c1ff766eeae51f04c9
Source-Link: googleapis/synthtool@9a7d9fb
@yoshi-automation
yoshi-automation requested review from a team and tswastNovember 19, 2020 14:06
@product-auto-labelproduct-auto-labelBot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Nov 19, 2020
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2020
@tswasttswast changed the title [CHANGE ME] Re-generated to pick up changes from synthtool.test: test on Python 3.9Dec 8, 2020
@tswasttswast added the automerge Merge the pull request once unit tests and other checks pass. label Dec 8, 2020
@gcf-merge-on-green

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2020
@tswast

Copy link
Copy Markdown
Contributor

Missing some wheels.

@tswast

Copy link
Copy Markdown
Contributor

Might be able to run these now that 3.9 wheels (linux-only) are published https://issues.apache.org/jira/browse/ARROW-10224

@busunkim96busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 28, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 28, 2020
@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2021
@tswast

Copy link
Copy Markdown
Contributor

I guess PyPI doesn't have 3.9 wheels for Arrow yet. It's only in the nightly location (until pyarrow 3.0 planned for this, I believe) apache/arrow#8386 (comment)

@tswast
tswast requested a review from plamutJanuary 7, 2021 16:46
@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2021
from .helpers import SCALAR_COLUMNS, SCALAR_COLUMN_NAMES, SCALAR_BLOCKS


pyarrow = pytest.importorskip("pyarrow")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only new logic. Everything else is just moving from test_reader_v1.py

@tswast

Copy link
Copy Markdown
Contributor

@plamut I'd appreciate a Python sanity check on this before merging. I split out the tests that depend on pyarrow to a separate test module so they're easier to skip on Python 3.9.

Comment threadnoxfile.py
"mock", "pytest", "pytest-cov",
)
session.install("-e", ".[fastavro,pandas,pyarrow]")
extras = "fastavro,pandas,pyarrow"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know synthtool will just revert this change, but I figure we can manually keep this in until pyarrow 3.0 is out.

@tswast
tswast merged commit 936e0a5 into masterJan 11, 2021
@tswast
tswast deleted the autosynth-synthtool branch January 11, 2021 15:41
@plamut

plamut commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

@tswast Sorry for missing this, this PR is so last year (pun intended) and I was recently added to several other groups, resulting in hundreds of GitHub notifications per day, making it easy to overlook stuff.

I also temporarily turned off most of the notifications until I fine-tune them, as there a still a couple of repositories I do want to watch.

Update: Glanced over the PR, looks fine. We can live with the non-persistent changes to the noxfile for awhile, but if it gets too annoying while waiting for pyarrow 3.0.0, we can still bake it into synth.py.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorageIssues related to the googleapis/python-bigquery-storage API.cla: yesThis human has signed the Contributor License Agreement.context: partial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@yoshi-automation@tswast@plamut@busunkim96@yoshi-kokoro