Uh oh!
There was an error while loading. Please reload this page.
feat: add reload argument to *Job.done() functions - #341
Conversation
This enables checking the job status without making an API call. It also fixes an inconsistency in `QueryJob`, where a job can be reported as "done" without having the results of a `getQueryResults` API call.
shollyman
left a comment
There was a problem hiding this comment.
Do the changes here indicate there's further changes for registering the done callback? My mental model has them independent, but I wanted to make sure.
| is_done = ( | ||
| # Only consider a QueryJob complete when we know we have the final | ||
| # query results available. | ||
| self._query_results is not None |
There was a problem hiding this comment.
checking: What about DDL statements, where we have no results? Or would this already retain the empty row iterator?
There was a problem hiding this comment.
DDL statements don't 404 for jobs.getQueryResults, do they? This is the full response object of jobs.getQueryResults, not just the rows.
tswast
commented
Oct 28, 2020
No callbacks here. Maybe when we implement the async client googleapis/google-cloud-python#15742
|
tswast
commented
Oct 28, 2020
Maybe you meant -- How do we get the needed arguments to |
This enables checking the job status without making an API call.
It also fixes an inconsistency in
QueryJob, where a job can bereported as "done" without having the results of a
getQueryResultsAPIcall.
Follow-up to #340