Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
perf: use jobs.getQueryResults to download result sets - #347
Closed
tswast wants to merge 8 commits into
Closed
Conversation
tswast
commented
Oct 27, 2020
ContributorAuthor
Based on #341 |
tswast
commented
Oct 28, 2020
| ) | ||
| self._query_results = None | ||
| self._get_query_results_kwargs = {} |
ContributorAuthor
There was a problem hiding this comment.
Does this need to be a thread-local variable?
ContributorAuthor
There was a problem hiding this comment.
Actually, the cached query results might need to be thread-local too. Imagine if two threads called result with different starting indexes and/or max results.
ContributorAuthor
There was a problem hiding this comment.
We'll also need some logic like
to see if we can use the cached page if result is called more than once
Since `getQueryResults` was already used to wait for the job to finish, this avoids an additional call to `tabledata.list`. The first page of results are cached in-memory. Additional changes will come in the future to avoid calling the BQ Storage API when the cached results contain the full result set.
tswastforce-pushed
the
optimized-query-getQueryResults
branch
from
October 29, 2020 19:15
7364196 to
983c8d2CompareAlso, move to thread-local variables for values that were intended to track parameters across methods.
tswast
marked this pull request as ready for review
October 30, 2020 21:40
startIndex is no longer passed to the iterator It is used in the initial (cached) call to getQueryResults
tswast
commented
Nov 2, 2020
| Iterator of row data | ||
| :class:`~google.cloud.bigquery.table.Row`-s. | ||
| """ | ||
| row_iterator = RowIterator( |
ContributorAuthor
There was a problem hiding this comment.
Be sure to populate extra args with the field projection. We only need rows and page token.
ContributorAuthor
Per our discussion, I'll be splitting this into 2 PRs:
I'll base them on the refactoring to split up the giant job module here: #361 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
getQueryResultswas already used to wait for the job to finish,this avoids an additional call to
tabledata.list. The first page ofresults are cached in-memory.
Additional changes will come in the future to avoid calling the BQ
Storage API when the cached results contain the full result set.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #362