Percents de-escaping isn't handled when no parameters are used in the dbapi.

[jimfulton]

>>> import google.cloud.bigquery.dbapi
>>> conn = google.cloud.bigquery.dbapi.connect()
/home/jim/p/g/python-bigquery/google/cloud/bigquery/client.py:444: UserWarning: Cannot create BigQuery Storage client, the dependency google-cloud-bigquery-storage is not installed.
 warnings.warn(
>>> cursor = conn.cursor()
>>> cursor.execute("select 'foo %%', %(x)s", dict(x=1))
>>> cursor.fetchall()
[Row(('foo %', 1), {'f0_': 0, 'f1_': 1})]
>>> cursor.execute("select 'foo %%'", dict(x=1))
>>> cursor.fetchall()
[Row(('foo %',), {'f0_': 0})]
>>> cursor.execute("select 'foo %%'")
>>> cursor.fetchall()
[Row(('foo %%',), {'f0_': 0})]

Bonus:

if people don't escape:

>>> cursor.execute("select 'foo %'")
>>> cursor.fetchall()
[Row(('foo %',), {'f0_': 0})]
>>> cursor.execute("select 'foo %'", dict(x=1))
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
 File "/home/jim/p/g/python-bigquery/google/cloud/bigquery/dbapi/_helpers.py", line 273, in with_closed_check
 return method(self, *args, **kwargs)
 File "/home/jim/p/g/python-bigquery/google/cloud/bigquery/dbapi/cursor.py", line 172, in execute
 formatted_operation = _format_operation(operation, parameters=parameters)
 File "/home/jim/p/g/python-bigquery/google/cloud/bigquery/dbapi/cursor.py", line 460, in _format_operation
 return _format_operation_dict(operation, parameters)
 File "/home/jim/p/g/python-bigquery/google/cloud/bigquery/dbapi/cursor.py", line 434, in _format_operation_dict
 return operation % formatted_params
ValueError: unsupported format character ''' (0x27) at index 13

[jimfulton]

FTR, I have a local fix. It's pretty simple. In cursor.py:

@@ -441,7 +461,7 @@ def _format_operation(operation, parameters=None):
 ``parameters`` argument.
 """
 if parameters is None or len(parameters) == 0:
- return operation
+ return operation.replace("%%", "%")
 
 if isinstance(parameters, collections_abc.Mapping):

[plamut]

@jimfulton So the expected behavior is to always de-escape in absence of parameters, no matter what?

It might be breaking for some of the existing parameter-less queries that happen to contain %%, but it will at least be clear that de-escaping is consistently always applied.

[jimfulton]

I think de-escaping has to be done consistently.

I tripped over this while testing the SQLAlchemy integration, which assumes consistent de-escaping.

[plamut]

Fair enough. We do need to assure a good changelog message, though (note to self when merging the PR).