Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: add a static copy of legacy proto-based types - #1000

Merged
tswast merged 7 commits into
googleapis:v3from
plamut:iss-999
Oct 6, 2021
Merged

feat: add a static copy of legacy proto-based types#1000
tswast merged 7 commits into
googleapis:v3from
plamut:iss-999

Conversation

@plamut

Copy link
Copy Markdown
Contributor

Closes#999.

Adding unmaintained legacy types definitions.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut
plamut requested review from a team and tswastOctober 1, 2021 15:08
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 1, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2021
"use types defined in google.cloud.bigquery instead."
)

warnings.warn(_LEGACY_MSG, category=DeprecationWarning)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- I had been thinking to add a request for import-time warnings.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@plamutplamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2021
@plamut

plamut commented Oct 1, 2021

Copy link
Copy Markdown
ContributorAuthor

Oh, wait... didn't we say we want to add back the proto* dependencies, so that those imports will not result in an error? Maybe as a "legacy_types" extra?

And what about the intersphinx links? Should we perhaps expose these models in the docs with a big fat "OBSOLETE!" warning at the top?

@tswast

@plamutplamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 1, 2021
@tswast

Copy link
Copy Markdown
Contributor

Oh, wait... didn't we say we want to add back the proto* dependencies, so that those imports will not result in an error? Maybe as a "legacy_types" extra?

Yes, please. I think we've added the BQ Storage API as a required dependency now, right? That should mean we pull those in transitively anyway, but it wouldn't hurt to be explicit.

And what about the intersphinx links? Should we perhaps expose these models in the docs with a big fat "OBSOLETE!" warning at the top?

Yeah, let's make sure we generate docs for it, but with a warning & link to our migration guide.

@plamutplamut removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2021
@plamut
plamut requested review from tswast and removed request for tswastOctober 5, 2021 14:44
@tswast
tswast merged commit 71dde11 into googleapis:v3Oct 6, 2021
@plamut
plamut deleted the iss-999 branch October 16, 2021 11:08
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@plamut@tswast@tseaver