Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: allow queryJob.result() to be called on a dryRun - #1015

Merged
tswast merged 3 commits into
googleapis:mainfrom
steffnay:dry_run_results
Oct 13, 2021
Merged

feat: allow queryJob.result() to be called on a dryRun#1015
tswast merged 3 commits into
googleapis:mainfrom
steffnay:dry_run_results

Conversation

@steffnay

@steffnaysteffnay commented Oct 11, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#1012 🦕

@steffnay
steffnay requested review from a team and loferrisOctober 11, 2021 21:45
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2021
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 11, 2021
tswast
tswast suggested changes Oct 11, 2021
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify the tests a bit.

Comment threadtests/unit/job/test_query.py Outdated
Comment threadtests/unit/job/test_query.py Outdated
Comment threadtests/unit/job/test_query.py

calls = conn.api_request.mock_calls
self.assertEqual(result, None)
self.assertEqual(calls, [])

@tswasttswastOct 11, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for checking that there were no API requests.

tswast
tswast reviewed Oct 12, 2021
View reviewed changes
Comment threadgoogle/cloud/bigquery/job/query.py Outdated
@steffnay
steffnay requested a review from tswastOctober 12, 2021 21:38
@tswast
tswast merged commit 685f06a into googleapis:mainOct 13, 2021
@tswast

tswast commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

Thanks @steffnay !

@release-pleaserelease-pleaseBot mentioned this pull request Jan 4, 2022
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@steffnay@abdelmegahedgoogle
feat: allow queryJob.result() to be called on a dryRun (googleapis#1015)
0742cf2
* feat: allow queryJob.result() to be called on a dryRun
* update to return EmptyRowIterator
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@loferrisloferrisAwaiting requested review from loferris
1 more reviewer
@tswasttswasttswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: allow QueryJob.result() to be called on a dryRun query

2 participants

@steffnay@tswast