Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: support Python 3.10 - #1043

Merged
tswast merged 7 commits into
mainfrom
issue1006-python310
Nov 3, 2021
Merged

feat: support Python 3.10#1043
tswast merged 7 commits into
mainfrom
issue1006-python310

Conversation

@tswast

@tswasttswast commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#1006 🦕
Towards googleapis/python-bigquery-datatransfer#244

@tswast
tswast requested a review from a teamNovember 3, 2021 14:42
@tswast
tswast requested a review from a team as a code ownerNovember 3, 2021 14:42
@tswast
tswast requested review from a team, loferris and shollymanNovember 3, 2021 14:42
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2021
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 3, 2021

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the Samples check with Python 3.10? And shouldn't we also run the system tests with the latest supported Python version?

Currently we only run them with Python 3.8.

Comment threadsamples/geography/requirements.txt
Comment threadsamples/snippets/requirements.txt
@tswast
tswast requested a review from plamutNovember 3, 2021 16:28
@tswast

Copy link
Copy Markdown
ContributorAuthor

Need to skip installing geopandas on 3.10

@tswast

Copy link
Copy Markdown
ContributorAuthor

I didn't see an open issue for geopandas Python 3.10 support, so I filed geopandas/geopandas#2212

@tswasttswast added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Nov 3, 2021
@tswast

Copy link
Copy Markdown
ContributorAuthor

Mailed internal change 407388245 to enable system tests on Python 3.10

@tswast
tswast merged commit 5bbb832 into mainNov 3, 2021
@tswast
tswast deleted the issue1006-python310 branch November 3, 2021 19:09
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
* feat: support Python 3.10
* fix pandas deps to match reality
* run system tests with 3.10
* avoid geopandas on Python 3.10
* install google-cloud-bigquery from source
* update kokoro configs
* remove Python 2.7 config
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.10 support

3 participants

@tswast@tseaver@plamut