Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

cleanup: silence non-relevant system test warnings - #1068

Merged
plamut merged 1 commit into
googleapis:mainfrom
plamut:iss-1060
Nov 18, 2021
Merged

cleanup: silence non-relevant system test warnings#1068
plamut merged 1 commit into
googleapis:mainfrom
plamut:iss-1060

Conversation

@plamut

@plamutplamut commented Nov 17, 2021

Copy link
Copy Markdown
Contributor

Fixes#1060.

Instead of fighting with geo data and how to correctly compute the area, I opted for the same fix we used in #973.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut
plamut requested review from a team and tswastNovember 17, 2021 10:22
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2021
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 17, 2021
loferris
loferris approved these changes Nov 17, 2021
View reviewed changes

@loferrisloferris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plamut
plamut merged commit 1b5dc5c into googleapis:mainNov 18, 2021
@plamut
plamut deleted the iss-1060 branch November 18, 2021 07:23
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@plamut@abdelmegahedgoogle
cleanup: silence non-relevant system test warnings (googleapis#1068)
fb71292
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tswasttswastAwaiting requested review from tswast
2 more reviewers
@tseavertseavertseaver approved these changes
@loferrisloferrisloferris approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix warnings caused by library code when running system tests

3 participants

@plamut@tseaver@loferris