Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: promote RowIterator.to_arrow_iterable to public method - #1073

Merged
tswast merged 3 commits into
googleapis:mainfrom
judahrand:to_arrow_iterable
Nov 19, 2021
Merged

feat: promote RowIterator.to_arrow_iterable to public method#1073
tswast merged 3 commits into
googleapis:mainfrom
judahrand:to_arrow_iterable

Conversation

@judahrand

@judahrandjudahrand commented Nov 19, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#1072 🦕

@judahrand
judahrand requested review from a team and tswastNovember 19, 2021 11:29
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2021
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 19, 2021
@judahrand
judahrandforce-pushed the to_arrow_iterable branch 2 times, most recently from 9c42717 to dd57bb1CompareNovember 19, 2021 11:31
@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@tswasttswast changed the title Promote to_arrow_iterable to public methodfeat: promote RowIterator.to_arrow_iterable to public methodNov 19, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
tswast
tswast approved these changes Nov 19, 2021
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Comment threadgoogle/cloud/bigquery/table.py Outdated
@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
tswast
tswast reviewed Nov 19, 2021
View reviewed changes
Comment threadgoogle/cloud/bigquery/table.py Outdated
@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@tswast
tswast merged commit 21cd710 into googleapis:mainNov 19, 2021
@release-pleaserelease-pleaseBot mentioned this pull request Jan 4, 2022
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@judahrand@tswast@abdelmegahedgoogle
feat: promoteRowIterator.to_arrow_iterableto public method (googl…
e7d54a4
…eapis#1073)
* feat: promote `to_arrow_iterable` to public method
* use correct version number
* Update google/cloud/bigquery/table.py
Co-authored-by: Tim Swast <swast@google.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@tswasttswasttswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Promote _to_arrow_iterable to public method

3 participants

@judahrand@tswast@yoshi-kokoro