Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: return 403 when VPC-SC violation happens - #1131

Merged
tswast merged 2 commits into
googleapis:mainfrom
Erroration2022:patch-1
Feb 16, 2022
Merged

fix: return 403 when VPC-SC violation happens#1131
tswast merged 2 commits into
googleapis:mainfrom
Erroration2022:patch-1

Conversation

@Erroration2022

@Erroration2022Erroration2022 commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

This is fixing the issue where VPC-SC violation is not returning 403. Error message map does not recognize VPCSC policy violation error and will default to return an internal server error.

This is fixing the issue where VPC-SC violation is not returning 403. Error message map does not recognize VPCSC policy violation error and will default to return an internal server error.
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Feb 4, 2022
@Erroration2022
Erroration2022 marked this pull request as ready for review February 4, 2022 17:46
@Erroration2022
Erroration2022 requested review from a team and shollymanFebruary 4, 2022 17:46
@shollyman
shollyman requested a review from tswastFebruary 5, 2022 22:35
@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2022
@tswast

Copy link
Copy Markdown
Contributor

Merging blocked by googleapis/google-resumable-media-python#297

@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2022
@tswast
tswast merged commit f5daa9b into googleapis:mainFeb 16, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Feb 16, 2022
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
This is fixing the issue where VPC-SC violation is not returning 403. Error message map does not recognize VPCSC policy violation error and will default to return an internal server error.
Co-authored-by: Tim Swast <swast@google.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Erroration2022@tswast@yoshi-kokoro