Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v1 release - #1166
Merged
Conversation
busunkim96
requested review from
a team, parthea and tswast
and removed request for
a teamMarch 10, 2022 22:25
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by default. Update the connection tests to expect a value for `prettyPrint`.
…ddress (#942) * chore: update system tests and samples to use and @google.com email address * Add group prefix * fixed access entry some more
nicain
approved these changes
Mar 14, 2022
tswast
approved these changes
Mar 25, 2022
tswast
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Test failures look like a conflict between new pandas and old pyarrow, but probably not worth investigating further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow google-api-core<3.0.0dev on previous release of library. This will be followed by a release PR.