Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

test: Move tests/unit/helpers to tests/unit/_helpers - #1169

Merged
gcf-merge-on-green[bot] merged 2 commits into
googleapis:mainfrom
waltaskew:main
Mar 22, 2022
Merged

test: Move tests/unit/helpers to tests/unit/_helpers#1169
gcf-merge-on-green[bot] merged 2 commits into
googleapis:mainfrom
waltaskew:main

Conversation

@waltaskew

@waltaskewwaltaskew commented Mar 16, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Remove ambiguity between importing tests/unit/helpers and tests/unit/helpers.py
which can lead to import errors.

Renamed directory _helpers matches the google.cloud.bigquery._helpers module
being tested.

Fixes#1168 🦕

@waltaskew
waltaskew requested review from a team and tswastMarch 16, 2022 23:10
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Mar 16, 2022
@waltaskew
fix: move tests/unit/helpers to tests/unit/helpers
97e55ae
Remove ambiguity between importing tests/unit/helpers and tests/unit/helpers.py
which can lead to import errors.
Renamed directory _helpers matches the google.cloud.bigquery._helpers module
being tested.
@partheaparthea changed the title Move tests/unit/helpers to tests/unit/helperstest: Move tests/unit/helpers to tests/unit/_helpersMar 17, 2022
@partheaparthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 17, 2022
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 17, 2022
@tswast

tswast commented Mar 17, 2022

Copy link
Copy Markdown
Contributor

Re: Kokoro failures, the TestClient.test__initiate_resumable_upload test failures are due to a recent resumable media release. I believe it only affects the (overly strict) unit test assertions, and don't actually indicate a problem. That said, we'll need to patch that before we can merge this.

@waltaskew

waltaskew commented Mar 18, 2022

Copy link
Copy Markdown
ContributorAuthor

Re: Kokoro failures, the TestClient.test__initiate_resumable_upload test failures are due to a recent resumable media release. I believe it only affects the (overly strict) unit test assertions, and don't actually indicate a problem. That said, we'll need to patch that before we can merge this.

Is there an open issue for this? Anyone working on it? I can take a crack at it if no one else has already started.

@waltaskew

waltaskew commented Mar 22, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Re: Kokoro failures, the TestClient.test__initiate_resumable_upload test failures are due to a recent resumable media release. I believe it only affects the (overly strict) unit test assertions, and don't actually indicate a problem. That said, we'll need to patch that before we can merge this.

Look like this was fixed over here: #1171

Can we give this PR another shot at merging, @tswast ?

@tswasttswast added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. automerge Merge the pull request once unit tests and other checks pass. labels Mar 22, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 22, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 22, 2022
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit d7f3e8d into googleapis:mainMar 22, 2022
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 22, 2022
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@waltaskew@abdelmegahedgoogle
test: Move tests/unit/helpers to tests/unit/_helpers (googleapis#1169)
025a904
Remove ambiguity between importing tests/unit/helpers and tests/unit/helpers.py
which can lead to import errors.
Renamed directory _helpers matches the google.cloud.bigquery._helpers module
being tested.
Fixesgoogleapis#1168 🦕
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@tswasttswasttswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Import Ambiguity For 'google.cloud.bigquery.tests.unit.helpers'

4 participants

@waltaskew@tswast@parthea@yoshi-kokoro