Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: skip geography_as_object conversion for REPEATED fields - #1220

Merged
steffnay merged 2 commits into
googleapis:mainfrom
bnaul:repeated_geog
Apr 20, 2022
Merged

fix: skip geography_as_object conversion for REPEATED fields#1220
steffnay merged 2 commits into
googleapis:mainfrom
bnaul:repeated_geog

Conversation

@bnaul

Copy link
Copy Markdown
Contributor

Fixes#1213 🦕

I looked into adding a test for this specific case but the existing test data helpers don't seem to support REPEATED fields from what I could tell, sooooo I gave up...

@bnaul
bnaul requested review from a team and shollymanApril 15, 2022 14:26
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Apr 15, 2022
@bnaul

Copy link
Copy Markdown
ContributorAuthor

@tswast whaddya think? 🙂

@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2022
@tswasttswast added the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2022
@tswasttswast changed the title Skip geography_as_object conversion for REPEATED fieldsfix: skip geography_as_object conversion for REPEATED fieldsApr 20, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2022
@steffnay
steffnay merged commit 4d3d6ec into googleapis:mainApr 20, 2022
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Apr 20, 2022
@bnaul
bnaul deleted the repeated_geog branch April 25, 2022 12:15
waltaskew pushed a commit to waltaskew/python-bigquery that referenced this pull request Jul 20, 2022
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: xsPull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

geography_as_object=True fails if mode="REPEATED"

4 participants

@bnaul@tswast@steffnay@yoshi-kokoro