Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

docs(samples): table variable fix - #1287

Merged
gcf-merge-on-green[bot] merged 21 commits into
googleapis:mainfrom
adhiggs:adhiggs-patch-1
Jan 24, 2023
Merged

docs(samples): table variable fix#1287
gcf-merge-on-green[bot] merged 21 commits into
googleapis:mainfrom
adhiggs:adhiggs-patch-1

Conversation

@adhiggs

@adhiggsadhiggs commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

Updated table variable in "# Print row data in tabular format." to point at the correct table_id.

Fixes#1286

@adhiggs
adhiggs requested a review from a teamJuly 7, 2022 00:47
@adhiggs
adhiggs requested a review from a team as a code ownerJuly 7, 2022 00:47
@adhiggs
adhiggs requested review from a team, GaoleMeng and engelkeJuly 7, 2022 00:47
@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Jul 7, 2022

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jul 7, 2022
@adhiggsadhiggs changed the title Table variable fixVariable fixJul 7, 2022
@adhiggsadhiggs changed the title Variable fixfix: table variable fixJul 7, 2022
Updated table variable in "# Print row data in tabular format." to point at the correct table_id.
@partheaparthea changed the title fix: table variable fixdocs(samples): table variable fixJul 7, 2022
@partheaparthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 7, 2022
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 7, 2022
@adhiggs

adhiggs commented Jul 7, 2022

Copy link
Copy Markdown
ContributorAuthor

Not sure how to get these checks to pass. Thoughts?
(And thanks for the assist so far!)

@product-auto-labelproduct-auto-labelBot added the samples Issues that are directly related to samples. label Jul 8, 2022
@partheaparthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 10, 2022
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 10, 2022
@steffnay

Copy link
Copy Markdown
Contributor

Hey, @adhiggs, the Client.list_rows method accepts type Union[Table, TableListItem, TableReference, str] for this parameter, so I am not recognizing the reason for this change.

@adhiggs

Copy link
Copy Markdown
ContributorAuthor

Hi @steffnay, looping you in on bugs related, stay tuned.

@Vadoid

Copy link
Copy Markdown

Hi @steffnay this change is for clarity and consistency. In other code samples in https://cloud.google.com/bigquery/docs/samples/bigquery-browse-table the table variable passed to methods is 'table_id', except for the last example under "# Print row data in tabular format." where it's 'table', so the last code block wouldn't run while table variable is defined as 'table_id'.

@partheaparthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2022
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2022
@aribrayaribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2022
@adhiggs

Copy link
Copy Markdown
ContributorAuthor

Hi team! Is there anything blocking this item from being merged in?

@aribrayaribray added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 13, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2023
@shollymanshollyman added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 23, 2023
@yoshi-kokoroyoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 23, 2023
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit a71888a into googleapis:mainJan 24, 2023
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 24, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Jan 24, 2023
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
Updated table variable in "# Print row data in tabular format." to point at the correct table_id.
Fixes https://togithub.com/googleapis/python-bigquery/issues/1286
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.samplesIssues that are directly related to samples.size: xsPull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table variable correction in browse_table_data.py

9 participants

@adhiggs@steffnay@Vadoid@shollyman@parthea@meredithslota@yoshi-kokoro@aribray@dandhlee