Uh oh!
There was an error while loading. Please reload this page.
deps: support Pythons <4 - #1413
Conversation
cpcloud
commented
Nov 17, 2022
cc @tswast |
tswast
commented
Nov 17, 2022
@cpcloud I'm looking into this. It would be a departure from most of the other Google client libraries. Would you mind sharing some of the reasoning here why it's important to have a wider upper bound? I assume partially it's so it's easier to test with prerelease versions of Python? |
cpcloud
commented
Nov 17, 2022
@tswast The main reason is for testing new Python versions not necessarily pre-release only though, since 3.11 has been out for about a month. |
Uh oh!
There was an error while loading. Please reload this page.
cpcloud
commented
Nov 17, 2022
Should I put |
cpcloud
commented
Nov 17, 2022
Seems the CLA check is failing, but I have signed one according to the link. |
@cpcloud GH associated my gmail account with the change and NOT my google account and despite being a Googler and having my google address associated with my GH account, the CLA check only sees that chalmer.lowe@gmail.com made the suggested change and co-authored a minor tweak. I am looking into how to reset the author on that change I suggested so that we can get past the CLA problem. I attempted to reset the author using git on my local machine and push that change to GH, but it might have been pushed to your GH repo due to the various convolutions involved in pull requests, etc. Sigh. |
cpcloud
commented
Nov 17, 2022
@chalmerlowe I went ahead and squashed it down to just myself as the author. |
chalmerlowe
commented
Nov 17, 2022
sweet. thanks. |
tswast
commented
Nov 17, 2022
I think that'd be appropriate. I recall that |
cpcloud
commented
Nov 17, 2022
Thanks y'all! |
kevinfgordon
commented
Nov 17, 2022
@cpcloud thank you for this adjustment, I ran into the same issue trying to leverage this with 3.11 today. Eagerly awaiting the release to be completed. |
With googleapis#1413, python < 4 are all supported. Updating the README to communicate this (I had to look around before upgrading to 3.11)
Fixes#1412 🦕