Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

deps: remove upper bound on packaging dependency - #1440

Merged
tswast merged 6 commits into
mainfrom
issue1435-remove-packaging-upper-bound
Jan 13, 2023
Merged

deps: remove upper bound on packaging dependency#1440
tswast merged 6 commits into
mainfrom
issue1435-remove-packaging-upper-bound

Conversation

@tswast

@tswasttswast commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

Towards #1435

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #1435
Fixes#1400
🦕

@tswast
tswast requested review from a team and Neenu1995December 13, 2022 22:38
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Dec 13, 2022

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowechalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2022
@tswast

Copy link
Copy Markdown
ContributorAuthor

TODO: Need to investigate unit test failure:

______ TestPyarrowVersions.test_installed_version_returns_parsed_version _______
self = <tests.unit.test__helpers.TestPyarrowVersions testMethod=test_installed_version_returns_parsed_version>
def test_installed_version_returns_parsed_version(self):
versions = self._object_under_test()
with mock.patch("pyarrow.__version__", new="1.2.3"):
version = versions.installed_version
> assert version.major == 1
E AttributeError: 'Version' object has no attribute 'major'

@hirosassahirosassa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. I'm also struggling this problem.

I added a small comment.

Comment threadtesting/constraints-3.7.txt Outdated
opentelemetry-api==1.1.0
opentelemetry-instrumentation==0.20b0
opentelemetry-sdk==1.1.0
packaging==14.3

@hirosassahirosassaJan 4, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tswast It looks that the problem you suggest comes from this version constraint.

v14.3 of packaging has no major attribute:
https://github.com/pypa/packaging/blob/14.3/packaging/version.py#L268-L280

I think we need to update the lower bound, too.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parthea

Copy link
Copy Markdown
Contributor

@tswast See related issue #1400

@tswast
tswast enabled auto-merge (squash) January 13, 2023 17:15
@tswast
tswast merged commit 6088129 into mainJan 13, 2023
@tswast
tswast deleted the issue1435-remove-packaging-upper-bound branch January 13, 2023 17:41
@release-pleaserelease-pleaseBot mentioned this pull request Jan 13, 2023
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
* deps: remove upper bound on packaging dependency
Towards googleapis#1435
* install prerelease version of packaging
* bump minimum packaging version
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: xsPull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require packaging>=20.0

5 participants

@tswast@parthea@hirosassa@chalmerlowe@yoshi-kokoro