Uh oh!
There was an error while loading. Please reload this page.
feat: Update opentel to track bytes billed and processed for job queries - #1624
feat: Update opentel to track bytes billed and processed for job queries#1624MrwanBaghdad wants to merge 10 commits into
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
chalmerlowe
commented
Mar 29, 2024
In looking at this, as best I can tell, this looks like it relies upon AsyncJob, which we define elsewhere but when we define it, we don't initialize the attributes listed in this PR: namely I am considering going in an seeing about adding those attributes to AsyncJob, so that we can access them here. Am I missing something? |
tswast
left a comment
There was a problem hiding this comment.
We'll need some unit test coverage before merging this, too.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tswast
commented
Mar 29, 2024
I left some suggestions. I don't want to mislead folks by having these properties available on LoadJob for example, which is free and doesn't have such properties. |
chalmerlowe
commented
Apr 1, 2024
Agreed. |
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
chalmerlowe
commented
Apr 1, 2024
Couple of things:
See here for details on how to add a collaborator: |
chalmerlowe
commented
Apr 8, 2024
This has been migrated to a new PR. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Update opentel tracing tracking bytes billed and processed for job queries
Link to feature request