Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore: clean up BigQueryStorage import checks - #1680

Closed
Linchin wants to merge 3 commits into
googleapis:mainfrom
Linchin:bqstorage
Closed

chore: clean up BigQueryStorage import checks#1680
Linchin wants to merge 3 commits into
googleapis:mainfrom
Linchin:bqstorage

Conversation

@Linchin

@LinchinLinchin commented Oct 11, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Follow up of #1679

Also part of fixing #1430, this PR cleans up code that verifies BigQueryStorage extra can be successfully imported. It also:

  • Modifies some lines to comply with PEP-8 line length limit
  • Adds unit test for the added method

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#1430 🦕

@LinchinLinchin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 11, 2023
@Linchin
Linchin requested review from a team and shollymanOctober 11, 2023 22:34
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 11, 2023
@LinchinLinchin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 11, 2023
@LinchinLinchin added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 11, 2023
@Linchin
Linchin removed the request for review from shollymanOctober 11, 2023 23:40
@LinchinLinchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 11, 2023
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 11, 2023
tswast
tswast suggested changes Oct 13, 2023
View reviewed changes
Comment threadgoogle/cloud/bigquery/_helpers.py
Comment threadgoogle/cloud/bigquery/_helpers.py
Comment threadgoogle/cloud/bigquery/client.py
@LinchinLinchin mentioned this pull request Oct 23, 2023
Merged
4 tasks
Linchin added a commit to Linchin/python-bigquery that referenced this pull request Oct 24, 2023
@Linchin
address comments ingoogleapis#1680
0a3a86d
@Linchin

Linchin commented Oct 24, 2023

Copy link
Copy Markdown
ContributorAuthor

Closed due to too much merge conflicts, use #1699 instead.

@LinchinLinchin closed this Oct 24, 2023
tswast pushed a commit that referenced this pull request Oct 26, 2023
@Linchin
chore: refactor BigQueryStorageVersions (#1699)
e8da978
* chore: refactor BigQueryStorageVersions
* address comments in #1680
* add unit test
@Linchin
Linchin deleted the bqstorage branch October 30, 2023 23:37
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chalmerlowechalmerloweAwaiting requested review from chalmerlowe
1 more reviewer
@tswasttswasttswast requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cleanup: Use logic from BQStorageVersions and PyarrowVersions instead of comparing version strings outside of _helpers

3 participants

@Linchin@tswast@yoshi-kokoro