Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore: refactor version checks for pandas library - #1711

Merged
kiraksi merged 8 commits into
googleapis:mainfrom
kiraksi:refactor-version-checks-pandas
Nov 7, 2023
Merged

chore: refactor version checks for pandas library#1711
kiraksi merged 8 commits into
googleapis:mainfrom
kiraksi:refactor-version-checks-pandas

Conversation

@kiraksi

@kiraksikiraksi commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

Builds off of #1699

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#769 🦕

@kiraksi
kiraksi requested review from a team and obada-abNovember 2, 2023 21:39
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Nov 2, 2023
@kiraksi
kiraksi requested a review from tswastNovember 2, 2023 21:41
@Linchin

Linchin commented Nov 3, 2023

Copy link
Copy Markdown
Contributor

Thank you @kiraksi for opening your first PR! Looks like the mypy tests are failing:

nox > * mypy: failed
nox > * mypy_samples: failed

Please try to run the same nox sessions locally, and fix the errors (likely some format issues).

tswast
tswast suggested changes Nov 6, 2023
View reviewed changes
Comment threadgoogle/cloud/bigquery/_versions_helpers.py Outdated
Comment threadgoogle/cloud/bigquery/_versions_helpers.py Outdated
Comment threadgoogle/cloud/bigquery/client.py Outdated
Comment threadtests/unit/test__versions_helpers.py Outdated
chalmerlowe
chalmerlowe approved these changes Nov 7, 2023
View reviewed changes

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Confirm with Tim regarding the is not None comment.

tswast
tswast approved these changes Nov 7, 2023
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kiraksi
kiraksi merged commit afa9752 into googleapis:mainNov 7, 2023
@kiraksi
kiraksi deleted the refactor-version-checks-pandas branch November 7, 2023 21:08
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@tswasttswasttswast approved these changes
@chalmerlowechalmerlowechalmerlowe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor version checks for pandas, pyarrow

4 participants

@kiraksi@Linchin@tswast@chalmerlowe