Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

Revert "feat: removed pkg_resources from all test files and moved importlib into pandas extra" - #1739

Closed
tswast wants to merge 1 commit into
mainfrom
revert-1726-remove-pkgresources
Closed

Revert "feat: removed pkg_resources from all test files and moved importlib into pandas extra"#1739
tswast wants to merge 1 commit into
mainfrom
revert-1726-remove-pkgresources

Conversation

@tswast

Copy link
Copy Markdown
Contributor

Reverts #1726

@tswast
tswast requested review from a team and jainsahabNovember 28, 2023 22:24
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Nov 28, 2023

@partheaparthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss the next step in #1726, or via a new issue in this repo. We need to drop pkg_resources in order to support python 3.12.

@tswast

Copy link
Copy Markdown
ContributorAuthor

Removing the unnecessary "editable" install fixes this. google/bigframes#239 Closing.

@tswasttswast closed this Nov 29, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast@parthea