Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: Deserializing JSON subfields within structs fails - #1742

Merged
gcf-merge-on-green[bot] merged 13 commits into
googleapis:mainfrom
ericapetersson:main
Dec 14, 2023
Merged

fix: Deserializing JSON subfields within structs fails#1742
gcf-merge-on-green[bot] merged 13 commits into
googleapis:mainfrom
ericapetersson:main

Conversation

@ericapetersson

@ericapeterssonericapetersson commented Dec 4, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

… for deserializing json subfields from bigquery, this adds support for that.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1500 🦕

@ericapetersson
fix(Adding-support-to-dezerialize-json): currently there's no support…
e354860
… for dezerialising json structures from bigquery, this adds support for that
@ericapetersson
ericapetersson requested review from a team and mrfaizalDecember 4, 2023 10:54
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Dec 4, 2023
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 4, 2023
@LinchinLinchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2023
@parthea

parthea commented Dec 8, 2023

Copy link
Copy Markdown
Contributor

@ericapetersson, Thanks for opening a PR! Please could you add tests to close the coverage gap?

Name Stmts Miss Branch BrPart Cover Missing
--------------------------------------------------------------------------------------------------------
google/cloud/bigquery/_helpers.py 296 3 154 0 99% 244-247

@partheaparthea changed the title fix(Adding-support-to-deserializing-json): currently there's no support…fix: Deserializing JSON subfields within structs failsDec 8, 2023
@partheaparthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 8, 2023
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2023
@partheaparthea assigned Linchin and unassigned ericapeterssonDec 8, 2023
@parthea
parthea requested a review from LinchinDecember 8, 2023 15:11
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 8, 2023
@partheaparthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 8, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2023
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2023
@LinchinLinchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2023
@tswast

tswast commented Dec 13, 2023

Copy link
Copy Markdown
Contributor

Thanks so much for the contribution @ericapetersson ! This fix has been merged in #1587

@tswasttswast closed this Dec 13, 2023
@vvkhvvkh mentioned this pull request Dec 14, 2023
Closed
@tswasttswast reopened this Dec 14, 2023
@tswasttswast added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 14, 2023
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 14, 2023
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 0d93073 into googleapis:mainDec 14, 2023
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 14, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Dec 14, 2023
Merged
This was referenced Jan 17, 2024
Closed
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrfaizalmrfaizalAwaiting requested review from mrfaizal
@LinchinLinchinAwaiting requested review from Linchin
1 more reviewer
@tswasttswasttswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LinchinLinchin

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericapetersson@parthea@tswast@Linchin@yoshi-kokoro