Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: support JSON type in insert_rows and as a scalar query parameter - #1757

Merged
tswast merged 2 commits into
mainfrom
issue1756-json-insert_rows
Dec 19, 2023
Merged

feat: support JSON type in insert_rows and as a scalar query parameter#1757
tswast merged 2 commits into
mainfrom
issue1756-json-insert_rows

Conversation

@tswast

@tswasttswast commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#1756
🦕

@tswast
tswast requested review from a team and LinchinDecember 15, 2023 22:18
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Dec 15, 2023
This was referenced Dec 15, 2023
Merged
Closed
@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2023
chalmerlowe
chalmerlowe approved these changes Dec 19, 2023
View reviewed changes

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast
tswast merged commit 02a7d12 into mainDec 19, 2023
@tswast
tswast deleted the issue1756-json-insert_rows branch December 19, 2023 14:13
@release-pleaserelease-pleaseBot mentioned this pull request Dec 18, 2023
Merged
@brickerbricker mentioned this pull request Jan 10, 2024
Closed
This was referenced Jan 17, 2024
Closed
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@LinchinLinchinAwaiting requested review from Linchin
1 more reviewer
@chalmerlowechalmerlowechalmerlowe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@chalmerlowechalmerlowe

@LinchinLinchin

@kiraksikiraksi

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support JSON data type in insert_rows and as query parameters

5 participants

@tswast@chalmerlowe@Linchin@yoshi-kokoro@kiraksi