Uh oh!
There was an error while loading. Please reload this page.
fix: avoid unnecessary call to jobs.get in case of retriable query failure - #1797
fix: avoid unnecessary call to jobs.get in case of retriable query failure#1797tswast wants to merge 2 commits into
Conversation
tswast
commented
Jan 26, 2024
I was just reminded on googleapis/google-cloud-python#15732 today. We need to be careful with this change. The |
tswast
commented
Jan 29, 2024
An example of where doing jobs.getQueryResults can lead to ambiguity is the rateLimitExceeded error. With jobs.getQueryResults, if we get such an error, we don't really know if it's because of the general API-level rate limit or if it's because we hit the max number of concurrent queries and need to retry the whole query with a new job ID. By doing jobs.get, which doesn't raise on query job failures, we remove this ambiguity. A rateLimitExceeded on jobs.get will be that API-level error and never mean the query job failed for that reason. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes issue identified here: https://github.com/googleapis/python-bigquery/pull/1794/files#r1465230014
🦕