Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: updates a number of optional dependencies - #1864

Merged
gcf-merge-on-green[bot] merged 42 commits into
mainfrom
fix-simplify-dependencies
Mar 27, 2024
Merged

fix: updates a number of optional dependencies#1864
gcf-merge-on-green[bot] merged 42 commits into
mainfrom
fix-simplify-dependencies

Conversation

@chalmerlowe

Copy link
Copy Markdown
Collaborator

This fix updates a number of optional dependencies.
We use a different module import process (pytest.importorskip versus unittest.skipif).

This first major commit gets the ball rolling, there are gonna be a few additional commits to cover other files.

Fixes #<issue_number_goes_here> 🦕

@chalmerlowe
chalmerlowe requested review from a team and obada-abMarch 20, 2024 16:23
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Mar 20, 2024
@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Mar 20, 2024

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

chalmerloweand others added 19 commits March 21, 2024 12:05
Comment threadgoogle/cloud/bigquery/client.py
@chalmerlowechalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 26, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 26, 2024
@chalmerlowe
chalmerlowe requested a review from tswastMarch 27, 2024 13:34
Comment threadtests/system/test_client.py Outdated
Comment threadtests/system/test_client.py Outdated
Comment threadtests/unit/test_client.py Outdated
Comment threadtests/unit/conftest.py Outdated
Comment on lines +42 to +46
@pytest.fixture
def PYARROW_MINIMUM_VERSION(): # pragma: NO COVER
return "3.0.0"


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like this fixture is used?

Also if it is used, could this use the constant from _version_helpers as the tests do below?

chalmerloweand others added 3 commits March 27, 2024 11:07
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Comment threadtests/unit/conftest.py Outdated
@chalmerlowechalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Mar 27, 2024
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit c2496a1 into mainMar 27, 2024
@gcf-merge-on-green
gcf-merge-on-greenBot deleted the fix-simplify-dependencies branch March 27, 2024 16:18
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 27, 2024
@release-pleaserelease-pleaseBot mentioned this pull request Mar 27, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: lPull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@chalmerlowe@tswast@yoshi-kokoro