Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: creates linting-typing.cfg in presubmit - #1881

Merged
chalmerlowe merged 17 commits into
mainfrom
add-linting-typing-kokoro
Apr 3, 2024
Merged

fix: creates linting-typing.cfg in presubmit#1881
chalmerlowe merged 17 commits into
mainfrom
add-linting-typing-kokoro

Conversation

@chalmerlowe

Copy link
Copy Markdown
Collaborator

This PR creates a new configuration file in the .kokoro/presubmit folder.
The intent is to eventually move multiple checks out of the baseline Kokoro check and put them into their own Kokoro linting-typing:

The checks we are moving out include:

Typing:

  • mypy
  • mypy_samples
  • pytype

Linting/formatting:

  • lint
  • lint_setup_py
  • blacken

@chalmerlowe
chalmerlowe requested review from a team and PhongChuongMarch 29, 2024 11:19
@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Mar 29, 2024

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Mar 29, 2024
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 29, 2024
@chalmerlowe

chalmerlowe commented Mar 29, 2024

Copy link
Copy Markdown
CollaboratorAuthor

There is an internal Google CL (#618137967) to update the allowed env vars for this repository.
Once that gets approved, we should be able to confirm that this PR runs and determine what, if any time-savings are achieved by parallelizing these tests.

Comment thread.kokoro/presubmit/presubmit.cfg Outdated

@shollymanshollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying this a bit!

@chalmerlowechalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2024

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the comments.

Comment threadnoxfile.py Outdated
Comment threadnoxfile.py Outdated
Comment threadnoxfile.py Outdated
Comment threadnoxfile.py Outdated
Comment threadnoxfile.py Outdated
Comment threadnoxfile.py Outdated
@chalmerlowechalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 2, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 2, 2024
@chalmerlowechalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024
@chalmerlowechalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2024
Comment thread.kokoro/presubmit/linting-typing.cfg
Comment thread.kokoro/presubmit/linting-typing.cfg Outdated
Comment thread.kokoro/presubmit/linting-typing.cfg Outdated
Comment thread.kokoro/presubmit/presubmit.cfg
Comment thread.kokoro/presubmit/presubmit.cfg Outdated
@chalmerlowe
chalmerlowe merged commit c852c15 into mainApr 3, 2024
@chalmerlowe
chalmerlowe deleted the add-linting-typing-kokoro branch April 3, 2024 11:09
@release-pleaserelease-pleaseBot mentioned this pull request Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@chalmerlowe@shollyman@yoshi-kokoro