Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: support insertAll for range - #1909

Merged
Linchin merged 6 commits into
googleapis:mainfrom
Linchin:range_insertall
May 6, 2024
Merged

feat: support insertAll for range#1909
Linchin merged 6 commits into
googleapis:mainfrom
Linchin:range_insertall

Conversation

@Linchin

@LinchinLinchin commented May 2, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor
  • _range_to_json() conversion function to use insertAll
  • unit tests for the conversion functions
  • supports client.insert_rows() with dictionary and tuple, in the form of a dictionary or string literal
  • adds client.insert_rows() unit tests for each case we do not test for inserting different data types here
  • client.insert_row_from_dataframe() just works

Fixes #<issue_number_goes_here> 🦕

@Linchin
Linchin requested review from a team and leahecoleMay 2, 2024 22:09
@product-auto-labelproduct-auto-labelBot added the size: m Pull request size is medium. label May 2, 2024
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label May 2, 2024
@Linchin
Linchin removed the request for review from leahecoleMay 2, 2024 22:12
@LinchinLinchin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 2, 2024
@LinchinLinchin assigned shollyman and unassigned mrfaizalMay 2, 2024
alvarowolfx
alvarowolfx approved these changes May 3, 2024
View reviewed changes
Comment threadgoogle/cloud/bigquery/_helpers.py Outdated
@LinchinLinchin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 3, 2024
@Linchin
Linchin merged commit 74e75e8 into googleapis:mainMay 6, 2024
@release-pleaserelease-pleaseBot mentioned this pull request May 6, 2024
Merged
@LinchinLinchin mentioned this pull request May 10, 2024
Closed
6 tasks
This was referenced May 21, 2024
Closed
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@PhongChuongPhongChuongAwaiting requested review from PhongChuong
@shollymanshollymanAwaiting requested review from shollyman
1 more reviewer
@alvarowolfxalvarowolfxalvarowolfx approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@shollymanshollyman

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Linchin@alvarowolfx@tswast@shollyman@mrfaizal