Uh oh!
There was an error while loading. Please reload this page.
feat: updates to allow users to set max_stream_count - #2039
Conversation
kien-truong
commented
Oct 7, 2024
Shouldn't |
chalmerlowe
commented
Oct 7, 2024
In the question of which argument overrides which, I could probably be convinced to go either way. I purposely chose for
|
I am also in favor of having preserve_order override the max_streams_count setting. I think this would make it easier to use and understand. If Perhaps an error for when Edit: Actually I don't think the error is necessary for the same reason as why setting to 1 should always be ok. |
chalmerlowe
commented
Oct 7, 2024
let me cogitate on this. thanks for the input, both of you. |
chalmerlowe
commented
Oct 8, 2024
I revised the logic. Once the CI/CD checks pass, can you approve it, Suzy? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Suzy Mueller <suzmue@google.com>
Co-authored-by: Suzy Mueller <suzmue@google.com>
Co-authored-by: Suzy Mueller <suzmue@google.com>
…hon-bigquery into update-maxstreams
…hon-bigquery into update-maxstreams
…hon-bigquery into update-maxstreams
…hon-bigquery into update-maxstreams
Removed unnecessary else statement.
Adds a function `determine_requested_streams()` to compare `preserve_order` and the new argument `max_stream_count` to determine how many streams to request. ``` preserve_order (bool): Whether to preserve the order of streams. If True, this limits the number of streams to one (more than one cannot guarantee order). max_stream_count (Union[int, None]]): The maximum number of streams allowed. Must be a non-negative number or None, where None indicates the value is unset. If `max_stream_count` is set, it overrides `preserve_order`. ``` Fixes#2030 🦕
Adds a function
determine_requested_streams()to comparepreserve_orderand the new argumentmax_stream_countto determine how many streams to request.Fixes#2030 🦕