Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: add property for allowNonIncrementalDefinition for materialized view - #2084

Merged
chalmerlowe merged 3 commits into
googleapis:mainfrom
yu-iskw:issue-2083
Dec 4, 2024
Merged

feat: add property for allowNonIncrementalDefinition for materialized view#2084
chalmerlowe merged 3 commits into
googleapis:mainfrom
yu-iskw:issue-2083

Conversation

@yu-iskw

@yu-iskwyu-iskw commented Nov 28, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Solves #2083

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Reference

@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Nov 28, 2024
@yu-iskw
feat: property for allowNonIncrementalDefinition materialized view
98bc019
Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com>
format
Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com>
@yu-iskw
yu-iskw marked this pull request as ready for review November 28, 2024 09:08
@yu-iskw
yu-iskw requested review from a team and PhongChuongNovember 28, 2024 09:08
@chalmerlowechalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 2, 2024
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 2, 2024
chalmerlowe
chalmerlowe reviewed Dec 2, 2024
View reviewed changes
Comment threadtests/unit/test_table.py
chalmerlowe
chalmerlowe reviewed Dec 2, 2024
View reviewed changes
Comment threadgoogle/cloud/bigquery/table.py Outdated
@chalmerlowe

chalmerlowe commented Dec 2, 2024

Copy link
Copy Markdown
Collaborator

@yu-iskw

Thanks for adding this functionality. I added a couple of comments.
Please take a look.

@LinchinLinchin assigned chalmerlowe and unassigned whuffman36Dec 2, 2024
yu-iskwand others added 2 commits December 3, 2024 08:32
@yu-iskw@chalmerlowe
Update tests/unit/test_table.py
4f2479b
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
@yu-iskw@chalmerlowe
Update google/cloud/bigquery/table.py
cea663f
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
@yu-iskw

yu-iskw commented Dec 2, 2024

Copy link
Copy Markdown
ContributorAuthor

@chalmerlowe Thank you for the suggestion. I have taken them.

@yu-iskwyu-iskw changed the title Add property for allowNonIncrementalDefinition for materialized viewfeat: add property for allowNonIncrementalDefinition for materialized viewDec 4, 2024
chalmerlowe
chalmerlowe approved these changes Dec 4, 2024
View reviewed changes

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowechalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 4, 2024
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@chalmerlowe
chalmerlowe merged commit 3359ef3 into googleapis:mainDec 4, 2024
@release-pleaserelease-pleaseBot mentioned this pull request Nov 26, 2024
Merged
@yu-iskw

yu-iskw commented Dec 4, 2024

Copy link
Copy Markdown
ContributorAuthor

Thank you for merging this!

@chalmerlowe

chalmerlowe commented Dec 4, 2024

Copy link
Copy Markdown
Collaborator

@yu-iskw

I appreciate your time and effort to add this attribute to the library.

@chalmerlowechalmerlowe mentioned this pull request Dec 4, 2024
Closed
This was referenced Jan 21, 2025
Closed
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@PhongChuongPhongChuongAwaiting requested review from PhongChuong
1 more reviewer
@chalmerlowechalmerlowechalmerlowe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@chalmerlowechalmerlowe

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yu-iskw@chalmerlowe@whuffman36@yoshi-kokoro