Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 324
deps: Remove Python 3.7 and 3.8 as supported runtimes#2133
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
81b0993069e999a0d7fe27a19091fe3d79dc398a38cb2f9bc5b2bc1a2fe73f3f898ea20102f5fdf09b58bb3ac058b845cb3b07949d176c9796b5e6f529ae2178dcc33bb9508e79c799c991061db2cfa9b9dc16f139fc281e96edde9351341b69bbf6cddded1b2d6e0a98685186881b22dba096c3281c09d7e1d7f05f59c3a40d8bf7730ca2baee017d197ea048caeb78401a19369ca4788025c358c94be09c480dae76910e6d2572b518c9163abcfb36bd6620cdeacbd8931777666ea7f86ed15b414ed075423152c9a6be7a59a2fb6249f354034fb34e84c3fe1e4a1ffa1c2db7c51f04c8d7a145daf34File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -3,5 +3,5 @@ | ||
| # Only run this nox session. | ||
| env_vars: { | ||
| key: "NOX_SESSION" | ||
| value: "snippets-3.8" | ||
| value: "snippets-3.9" | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -3,5 +3,5 @@ | ||
| # Only run this nox session. | ||
| env_vars: { | ||
| key: "NOX_SESSION" | ||
| value: "system-3.8" | ||
| } | ||
| value: "system-3.9" | ||
| } | ||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -126,12 +126,12 @@ | ||
| if sys_major == 3 and sys_minor in (7, 8): | ||
| warnings.warn( | ||
| "The python-bigquery library will stop supporting Python 3.7 " | ||
| "and Python 3.8 in a future major release expected in Q4 2024. " | ||
| "The python-bigquery library no longer supports Python 3.7 " | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we raise an exception here instead of warning? WDYT? CollaboratorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can see about changing it to an Exception. | ||
| "and Python 3.8. " | ||
| f"Your Python version is {sys_major}.{sys_minor}.{sys_micro}. We " | ||
| "recommend that you update soon to ensure ongoing support. For " | ||
| "more details, see: [Google Cloud Client Libraries Supported Python Versions policy](https://cloud.google.com/python/docs/supported-python-versions)", | ||
| PendingDeprecationWarning, | ||
| FutureWarning, | ||
| ) | ||
| __all__ = [ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -835,8 +835,10 @@ def schema(self): | ||
| See | ||
| https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#ExternalDataConfiguration.FIELDS.schema | ||
| """ | ||
| prop = self._properties.get("schema", {}) | ||
| return [SchemaField.from_api_repr(field) for field in prop.get("fields", [])] | ||
| # TODO: The typehinting for this needs work. Setting this pragma to temporarily | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just a gentle reminder to add this to #2132 CollaboratorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All TODO items in this PR have been added to Issue #2132 | ||
| # manage a pytype issue that came up in another PR. See Issue: #2132 | ||
| prop = self._properties.get("schema", {}) # type: ignore | ||
| return [SchemaField.from_api_repr(field) for field in prop.get("fields", [])] # type: ignore | ||
| @schema.setter | ||
| def schema(self, value): | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -415,7 +415,9 @@ def __init__(self, job_id, client): | ||
| @property | ||
| def configuration(self) -> _JobConfig: | ||
| """Job-type specific configurtion.""" | ||
| configuration = self._CONFIG_CLASS() | ||
| # TODO: The typehinting for this needs work. Setting this pragma to temporarily | ||
| ||
| # manage a pytype issue that came up in another PR. See Issue: #2132 | ||
| configuration = self._CONFIG_CLASS() # pytype: disable=not-callable | ||
| configuration._properties = self._properties.setdefault("configuration", {}) | ||
| return configuration | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove
virtualenv==20.26.6because 3.7 is removed too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want virtualenv.
I am testing locally to see if we can simply install virtualenv without specifying a version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhere Owlbot.py did some post processing and reverted that bit of code to add that change back in because it pulled in the template for certain files and overwrote my changes.
I edited owlbot.py so that it will not touch certain templates AND so that for certain templates that it will protect the edits that we need to have go through.