Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore: refactor cell data parsing to use classes for easier overrides - #2144

Merged
tswast merged 6 commits into
mainfrom
tswast-refactor-cell-data
Mar 19, 2025
Merged

chore: refactor cell data parsing to use classes for easier overrides#2144
tswast merged 6 commits into
mainfrom
tswast-refactor-cell-data

Conversation

@tswast

@tswasttswast commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #1876
🦕

@tswast
tswast requested review from a team and mrfaizalMarch 11, 2025 21:43
@product-auto-labelproduct-auto-labelBot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery API. labels Mar 11, 2025
@tswast
tswast requested review from Linchin and chalmerlowe and removed request for mrfaizalMarch 11, 2025 21:43
@tswasttswast mentioned this pull request Mar 11, 2025
Merged
6 tasks
chalmerlowe
chalmerlowe reviewed Mar 18, 2025
View reviewed changes
Comment threadgoogle/cloud/bigquery/_helpers.py Outdated
chalmerlowe
chalmerlowe reviewed Mar 19, 2025
View reviewed changes
Comment threadtests/unit/_helpers/test_cell_data_parser.py Outdated
chalmerlowe
chalmerlowe approved these changes Mar 19, 2025
View reviewed changes

@chalmerlowechalmerlowe left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question about boilerplate copyright text.

That is not a show stopper.

It looks like coverage is grumbly about one of the lines in _helpers.py. Once that gets cleaned up, we should be good to go.

Gonna approve this.

@tswast
tswast merged commit 9acd9c1 into mainMar 19, 2025
@tswast
tswast deleted the tswast-refactor-cell-data branch March 19, 2025 15:17
chalmerlowe pushed a commit that referenced this pull request Mar 25, 2025
@tswast@chalmerlowe
chore: refactor cell data parsing to use classes for easier overrides (…
df4d12b
…#2144)
* chore: refactor cell data parsing to use classes for easier overrides
* improve error messages with urls for valueerrors
* Update tests/unit/_helpers/test_cell_data_parser.py
* remove unreachable code
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@LinchinLinchinAwaiting requested review from Linchin
2 more reviewers
@GarrettWuGarrettWuGarrettWu approved these changes
@chalmerlowechalmerlowechalmerlowe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@shollymanshollyman

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: xlPull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tswast@GarrettWu@chalmerlowe@shollyman