Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: add ability to set autodetect_schema query param in update_table - #2171

Merged
chalmerlowe merged 6 commits into
googleapis:mainfrom
TheNeuralBit:update-autodetect
May 12, 2025
Merged

feat: add ability to set autodetect_schema query param in update_table#2171
chalmerlowe merged 6 commits into
googleapis:mainfrom
TheNeuralBit:update-autodetect

Conversation

@TheNeuralBit

@TheNeuralBitTheNeuralBit commented May 1, 2025

Copy link
Copy Markdown
Contributor

Fixes#2170

@TheNeuralBit
TheNeuralBit requested review from a team and shollymanMay 1, 2025 19:58
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels May 1, 2025
@TheNeuralBitTheNeuralBit changed the title Add ability to set autodetectSchema query param in update_tablePATCH callAdd ability to set autodetect_schema query_paramMay 1, 2025
@chalmerlowechalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 2, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 2, 2025
@chalmerlowe

chalmerlowe commented May 2, 2025

Copy link
Copy Markdown
Collaborator

I reviewed this. I have a PR I want to merge into this branch, but there are some failing tests so I am working through that. More to come.

@TheNeuralBitTheNeuralBit changed the title Add ability to set autodetect_schema query_paramfeat: add ability to set autodetect_schema query param in update_tableMay 7, 2025
@chalmerlowechalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 7, 2025
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 7, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 7, 2025
chalmerlowe
chalmerlowe suggested changes May 12, 2025
View reviewed changes

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a couple preferences. If you are amenable, please update.
If tests pass, we can approve.

Comment threadtests/system/test_client.py
Comment threadtests/system/test_client.py Outdated
Comment threadtests/system/test_client.py Outdated
@TheNeuralBit

TheNeuralBit commented May 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks @chalmerlowe I applied all your suggestions in b329cd0. Do you know why the test runs seem to be stuck?

@chalmerlowechalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 12, 2025
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 12, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 12, 2025
chalmerlowe
chalmerlowe approved these changes May 12, 2025
View reviewed changes

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe
chalmerlowe merged commit 57f940d into googleapis:mainMay 12, 2025
@release-pleaserelease-pleaseBot mentioned this pull request May 12, 2025
Merged
This was referenced May 28, 2025
Closed
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shollymanshollymanAwaiting requested review from shollyman
1 more reviewer
@chalmerlowechalmerlowechalmerlowe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@chalmerlowechalmerlowe

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update_table should support setting autodetectSchema query param in PATCH call

5 participants

@TheNeuralBit@chalmerlowe@alvarowolfx@Linchin@yoshi-kokoro