Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 325
feat: Add dtype parameters to to_geodataframe functions#2176
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
2bd1992b4edb9ce49e808baa598179cde61ee5533ad3314e0File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -82,7 +82,11 @@ pandas = [ | ||
| ipywidgets = ["ipywidgets >= 7.7.1", "ipykernel >= 6.2.0"] | ||
| geopandas = ["geopandas >= 0.9.0, < 2.0.0", "Shapely >= 1.8.4, < 3.0.0"] | ||
| ipython = ["ipython >= 7.23.1", "bigquery-magics >= 0.6.0"] | ||
| tqdm = ["tqdm >= 4.7.4, < 5.0.0"] | ||
| matplotlib = [ | ||
| "matplotlib >= 3.7.1, <= 3.9.2; python_version == '3.9'", | ||
| "matplotlib >= 3.10.3; python_version >= '3.10'", | ||
| ] | ||
| tqdm = ["tqdm >= 4.23.4, < 5.0.0"] | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [No action required] I'm curious. What forced the tqdm upgrade? 4.23.4 is still quite old, so I'm OK with this. I don't think we need to support folks who are stuck in 2016 for 4.7.4. CollaboratorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 4.7.4 produced an error during unit tests that indicated something to the effect of:
I opted for 4.23.4 because it is the same version we are using in | ||
| opentelemetry = [ | ||
| "opentelemetry-api >= 1.1.0", | ||
| "opentelemetry-sdk >= 1.1.0", | ||
| @@ -93,7 +97,7 @@ bigquery_v2 = [ | ||
| "protobuf >= 3.20.2, < 7.0.0, != 4.21.0, != 4.21.1, != 4.21.2, != 4.21.3, != 4.21.4, != 4.21.5", # For the legacy proto-based types. | ||
| ] | ||
| all = [ | ||
| "google-cloud-bigquery[bqstorage,pandas,ipywidgets,geopandas,ipython,tqdm,opentelemetry,bigquery_v2]", | ||
| "google-cloud-bigquery[bqstorage,pandas,ipywidgets,geopandas,ipython,matplotlib,tqdm,opentelemetry,bigquery_v2]", | ||
| ] | ||
| [tool.setuptools.dynamic] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -29,4 +29,4 @@ pyarrow==4.0.0 | ||
| python-dateutil==2.8.2 | ||
| requests==2.21.0 | ||
| Shapely==1.8.4 | ||
| tqdm==4.7.4 | ||
| matplotlib==3.7.1 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about this change. What inherited members were causing problems? IIRC, there's a few methods defined in the base class for jobs that we want to make sure are documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change re:
autodoc_default_optionsinconf.pywas added by Owlbot.Same thing for the removal of:
"google/cloud/bigquery_v2/**", # Legacy proto-based types.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there plans to restore the missing docs, such as
reservationandjob_timeout_mson the*JobConfigclasses?