Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

test: remove pragma - #2212

Merged
chalmerlowe merged 3 commits into
mainfrom
test-remove-pragma
Jun 9, 2025
Merged

test: remove pragma#2212
chalmerlowe merged 3 commits into
mainfrom
test-remove-pragma

Conversation

@chalmerlowe

@chalmerlowechalmerlowe commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator

Three more fixes for Issue: 2132. This will close out that Issue.

  • Removes a # pragma: no cover statement. There was a test that covered the condition in question but for some reason, during the process of removing Python 3.7 and 3.8 runtime dependencies, coverage was not detecting it. coverage now correctly identifies the existing test as providing unit test coverage.

  • Added conditionals to handle differences between how pandas 1.3 and pandas 2.0+ handle timestamps (us vs ns).

Fixes#2132 🦕

@chalmerlowe
chalmerlowe requested review from a team and PhongChuongJune 9, 2025 11:31
@product-auto-labelproduct-auto-labelBot added the size: xs Pull request size is extra small. label Jun 9, 2025
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jun 9, 2025
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 9, 2025
@chalmerlowe
chalmerlowe requested review from leahecole and removed request for PhongChuongJune 9, 2025 12:49
@chalmerlowe
chalmerlowe merged commit 99493bf into mainJun 9, 2025
@chalmerlowe
chalmerlowe deleted the test-remove-pragma branch June 9, 2025 16:31
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup tech debt from removing Python 3.7 and 3.8

2 participants

@chalmerlowe@leahecole