Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 324
feat: adds time_zone to external config and load job#2229
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
07c66aae02e24bff0645a5e6e619ee7e7dec584a5a10f7cd4dd6f7ffFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to https://github.com/googleapis/python-bigquery/pull/2229/files#r2191183829, I think in general we need to test against to/from_api_repr and the property itself. The same goes for CollaboratorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The pattern/philosophy for Here, the author chose to test each attribute in more of a stand alone fashion using a trifecta of tests:
But: Examples:
missingConfirms that when the target class is created, the attribute is not populated hitSets (behind the scenes using setterSets the value of the attribute directly using the setter function CollaboratorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added a |
Uh oh!
There was an error while loading. Please reload this page.