Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

refactor: update Job classes to use common _properties pattern - #323

Merged
steffnay merged 2 commits into
googleapis:masterfrom
tswast:issue297-refactor-job-classes
Oct 16, 2020
Merged

refactor: update Job classes to use common _properties pattern#323
steffnay merged 2 commits into
googleapis:masterfrom
tswast:issue297-refactor-job-classes

Conversation

@tswast

@tswasttswast commented Oct 13, 2020

Copy link
Copy Markdown
Contributor

Instead of mixing _properties and plain-old Python objects, always use
_properties as the source of truth.

This has the side-effect of properly reloading the whole job resource.
Previously some properties were not reloaded.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #297 🦕

Instead of mixing _properties and plain-old Python objects, always use
_properties as the source of truth.
This has the side-effect of properly reloading the whole job resource.
Previously some properties were not reloaded.
@tswast
tswast requested a review from a teamOctober 13, 2020 18:49
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2020
@tswasttswast mentioned this pull request Oct 13, 2020
@steffnay
steffnay merged commit d093cd4 into googleapis:masterOct 16, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast@steffnay