Uh oh!
There was an error while loading. Please reload this page.
feat: add BigQuery storage client support to DB API - #36
Conversation
tswast
left a comment
There was a problem hiding this comment.
General structure LGTM. Replacing self._query_data with an iterable that calls the BQ Storage API under the covers is exactly what I imagined.
Once the PR is ready, let's have @shollyman or someone he delegates to do the final review.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
The coverage failure is due to Python 2.7 unit tests are not run on Kokoro: The tests pass just fine locally, and the total coverage is 100%. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
googlebot
commented
Feb 19, 2020
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
googlebot
commented
Feb 19, 2020
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Uh oh!
There was an error while loading. Please reload this page.
plamut
commented
Feb 20, 2020
@tseaver As a co-author of one of the changes, please just appease the CLA bot, thanks! |
shollyman
left a comment
There was a problem hiding this comment.
Thanks for this. We'll want to update this from v1beta1->v1 in the near future, not sure how you'd like to track that.
plamut
commented
Feb 21, 2020
@shollyman Track in the sense of the tasks that need to be done for the promotion to GA? A GitHub issue for it would be just fine. |
plamut
commented
Feb 23, 2020
@tseaver Friendly ping, the CLA bot still needs confirmation from you. Thanks! |
tseaver
commented
Feb 25, 2020
@googlebot I signed it! |
googlebot
commented
Feb 25, 2020
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
yan-hic
commented
Jun 9, 2020
Can usage for this be updated at https://github.com/mxmzdlv/pybigquery/blob/master/README.rst#usage ? |
yan-hic
commented
Apr 7, 2021
To be closed as per googleapis/python-bigquery-sqlalchemy#61 (comment) ? |
plamut
commented
Apr 13, 2021
@yiga2 Sorry, I'm not following? What should be closed, this PR has been merged? |
yan-hic
commented
Apr 13, 2021
My bad - meant to close googleapis/python-bigquery-sqlalchemy#41 |
Closes#16.
The title says it all. Details in the ticket description.
PR checklist: