Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: allow routine references - #378

Merged
tswast merged 5 commits into
googleapis:masterfrom
cguardia:353-allow-routine-references
Nov 10, 2020
Merged

feat: allow routine references#378
tswast merged 5 commits into
googleapis:masterfrom
cguardia:353-allow-routine-references

Conversation

@cguardia

@cguardiacguardia commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

The Access property of a dataset now allows references to Routine entities.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#353 🦕

@cguardia
cguardia requested review from a team and tswastNovember 10, 2020 09:39
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 10, 2020
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Nov 10, 2020
@cguardiacguardia changed the title 353 allow routine referencesfeat: allow routine referencesNov 10, 2020
@cguardia
cguardiaforce-pushed the 353-allow-routine-references branch from f645e49 to 76eeb96CompareNovember 10, 2020 10:15
tswast
tswast approved these changes Nov 10, 2020
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast
tswast merged commit f9480dc into googleapis:masterNov 10, 2020
@cguardia
cguardia deleted the 353-allow-routine-references branch November 11, 2020 06:57
@release-pleaserelease-pleaseBot mentioned this pull request Jan 4, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@tswasttswasttswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement: Authorized UDF support for dataset Access

2 participants

@cguardia@tswast