Uh oh!
There was an error while loading. Please reload this page.
refactor: move system tests into tests/system directory - #475
Conversation
This aligns more closely with the templates from synthtool.
tswast
commented
Jan 19, 2021
prerelease-deps-3.8 test failures are both in the unit tests. https://source.cloud.google.com/results/invocations/aed3c05e-366a-404e-b90a-ecb134327e41/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-bigquery%2Fpresubmit%2Fprerelease-deps-3.8/log Neither seem particularly related to pyarrow (failure due to bad nightly) or to this change. Perhaps there's some state that's being held onto when the unit tests are run in the same |
plamut
left a comment
There was a problem hiding this comment.
Apart from a license header nit, it looks good to me. 👍
Uh oh!
There was an error while loading. Please reload this page.
| IPython = pytest.importorskip("IPython") | ||
| io = pytest.importorskip("IPython.utils.io") | ||
| pandas = pytest.importorskip("pandas") | ||
| tools = pytest.importorskip("IPython.testing.tools") | ||
| interactiveshell = pytest.importorskip("IPython.terminal.interactiveshell") |
There was a problem hiding this comment.
Nice, this is IMO more clean that those skipIf decorators. 👍
| JOB_TIMEOUT = 120 # 2 minutes | ||
| WHERE = os.path.abspath(os.path.dirname(__file__)) | ||
| JOB_TIMEOUT = 120 # 2 minute | ||
| DATA_PATH = pathlib.Path(__file__).parent.parent / "data" |
There was a problem hiding this comment.
Love these small improvements and utilizing the goodies Python 3 offers!
Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
This aligns more closely with the templates from synthtool.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #366