Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore: use 3.8 for blacken session - #653

Merged
gcf-merge-on-green[bot] merged 4 commits into
masterfrom
busunkim96-patch-3
May 7, 2021
Merged

chore: use 3.8 for blacken session#653
gcf-merge-on-green[bot] merged 4 commits into
masterfrom
busunkim96-patch-3

Conversation

@busunkim96

@busunkim96busunkim96 commented May 6, 2021

Copy link
Copy Markdown
Contributor

@busunkim96
busunkim96 requested review from a team, plamut and stephaniewang526 and removed request for a teamMay 6, 2021 14:37
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2021
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label May 6, 2021
@tseaver

tseaver commented May 6, 2021

Copy link
Copy Markdown
Contributor

@busunkim96 I don't understand the pytype failure: it must presumably fail on master as well?

@plamut

plamut commented May 7, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

I checked and it indeed fails on master. I wonder how that could have happened, perhaps a dependency was updated and caused this error.

Edit: And that's indeed the case, attrs==21.1.0 caused this. There's even a revert, albeit for different reasons from what I can see.

A possible workaround is to install an older version of attrs before running pytype:

session.install("attrs==20.3.0")

Edit 2:This should fix it for now. (update: merged)

@plamutplamut mentioned this pull request May 7, 2021
Merged
4 tasks
@plamutplamut added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels May 7, 2021
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 7, 2021
@plamutplamut added the automerge Merge the pull request once unit tests and other checks pass. label May 7, 2021
@gcf-merge-on-green

gcf-merge-on-greenBot commented May 7, 2021

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label May 7, 2021
@busunkim96busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label May 7, 2021
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 240d1d2 into masterMay 7, 2021
@gcf-merge-on-green
gcf-merge-on-greenBot deleted the busunkim96-patch-3 branch May 7, 2021 22:14
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label May 7, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@plamutplamutAwaiting requested review from plamut
@stephaniewang526stephaniewang526Awaiting requested review from stephaniewang526
1 more reviewer
@tseavertseavertseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@busunkim96@tseaver@plamut@yoshi-kokoro