Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: executemany rowcount only reflected the last execution - #660

Merged
plamut merged 1 commit into
masterfrom
riversnake-fix-659
May 12, 2021
Merged

fix: executemany rowcount only reflected the last execution#660
plamut merged 1 commit into
masterfrom
riversnake-fix-659

Conversation

@jimfulton

@jimfultonjimfulton commented May 11, 2021

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#659 🦕

@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label May 11, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label May 11, 2021
@jimfulton
jimfulton marked this pull request as ready for review May 11, 2021 17:13
@jimfulton
jimfulton requested review from a team and shollyman and removed request for a teamMay 11, 2021 17:13
plamut
plamut approved these changes May 11, 2021
View reviewed changes

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plamut
plamut merged commit aeadc8c into masterMay 12, 2021
@plamut
plamut deleted the riversnake-fix-659 branch May 12, 2021 10:22
@release-pleaserelease-pleaseBot mentioned this pull request Jan 4, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shollymanshollymanAwaiting requested review from shollyman
1 more reviewer
@plamutplamutplamut approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DB API rowcount incorrect for executemany

2 participants

@jimfulton@plamut