Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

refactor: blacken samples - #766

Closed
tswast wants to merge 3 commits into
googleapis:masterfrom
tswast:issue765-blacken-samples
Closed

refactor: blacken samples#766
tswast wants to merge 3 commits into
googleapis:masterfrom
tswast:issue765-blacken-samples

Conversation

@tswast

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#765 🦕

@tswast
tswast requested a review from a teamJuly 14, 2021 20:32
@tswast
tswast requested a review from a team as a code ownerJuly 14, 2021 20:32
@tswast
tswast requested review from a team, crwilcox and loferris and removed request for a teamJuly 14, 2021 20:32
@product-auto-labelproduct-auto-labelBot added api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Jul 14, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2021
@tswasttswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2021
@tswast

Copy link
Copy Markdown
ContributorAuthor

I noticed some conflicts with pre-commit and the version of black used in samples sessions. Mailed googleapis/synthtool#1158 to address that.

@plamut

Copy link
Copy Markdown
Contributor

I noticed some conflicts with pre-commit and the version of black used in samples sessions.

Aha, so that's why the lint check failed, one of the snippets was still re-formatted.

Ignoring that, the PR looks good.

Turns out they were already blackened.
@tswast

Copy link
Copy Markdown
ContributorAuthor

Hmm... Turns out these were already being blackened by the root noxfile. Twice, actually, due to docs and samples included here:

BLACK_PATHS= ("docs", "google", "samples", "tests", "noxfile.py", "setup.py")

Since we've still got a mess of files in the root samples/ dir like https://github.com/googleapis/python-bigquery/blob/master/samples/add_empty_column.py

I think it'd be best to wait on this until we do something like #203 (We'll have to do the move in two phases to avoid breaking cloud.google.com links)

@tswasttswast closed this Jul 15, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

blacken samples using templated noxfile

3 participants

@tswast@plamut@tseaver