Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: use a larger chunk size when loading data - #799

Merged
tswast merged 3 commits into
masterfrom
riversnake-fix-chunk-size
Jul 22, 2021
Merged

fix: use a larger chunk size when loading data#799
tswast merged 3 commits into
masterfrom
riversnake-fix-chunk-size

Conversation

@jimfulton

@jimfultonjimfulton commented Jul 22, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixesgoogleapis/google-resumable-media-python#238 🦕

@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jul 22, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2021
@jimfultonjimfulton changed the title The chunk size used for data uploads was too small (1MB). Now it's 10…fix: The chunk size used for data uploads was too smallJul 22, 2021
@jimfulton
jimfulton marked this pull request as ready for review July 22, 2021 18:13
@jimfulton
jimfulton requested review from a team and stephaniewang526 and removed request for a teamJuly 22, 2021 18:13
@tswasttswast mentioned this pull request Jul 22, 2021
Merged
@tswasttswast changed the title fix: The chunk size used for data uploads was too smallfix: use a larger chunk size when loading dataJul 22, 2021
tswast
tswast approved these changes Jul 22, 2021
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast
tswast merged commit b804373 into masterJul 22, 2021
@tswast
tswast deleted the riversnake-fix-chunk-size branch July 22, 2021 18:36
@tswasttswast mentioned this pull request Jul 26, 2021
Closed
@release-pleaserelease-pleaseBot mentioned this pull request Jan 4, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephaniewang526stephaniewang526Awaiting requested review from stephaniewang526
2 more reviewers
@tseavertseavertseaver approved these changes
@tswasttswasttswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uploads Using Python Google Cloud Storage/Bigquery Client Libraries are Very Slow

3 participants

@jimfulton@tseaver@tswast