Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore: remove local test_utils directory - #89

Merged
plamut merged 1 commit into
googleapis:masterfrom
plamut:iss-88
Apr 30, 2020
Merged

chore: remove local test_utils directory#89
plamut merged 1 commit into
googleapis:masterfrom
plamut:iss-88

Conversation

@plamut

Copy link
Copy Markdown
Contributor

Closes#88. 🦕

Test utils are now available in their own repo, meaning that we can remove the local copy of it.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamutplamut added the type: cleanup An internal cleanup or hygiene concern. label Apr 29, 2020
@plamut
plamut requested a review from shollymanApril 29, 2020 13:31
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2020
@plamut
plamut requested review from HemangChothani and removed request for shollymanApril 29, 2020 13:48

@HemangChothaniHemangChothani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
System tests failed which is not relevant to changes.

@plamutplamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2020
@plamut

plamut commented Apr 30, 2020

Copy link
Copy Markdown
ContributorAuthor

I noticed that system test failure on another branch, too, but thought it has something to do with changes I was making to how BQ Storage client is used. I now see that it can also happen on master with a few unrelated modifications.

I cannot reproduce it locally, however, I only observed it on Kokoro. I restarted the checks, and if they fail again for the same reason, I will submit the workaround from another branch in a new PR.

Edit: The failure did not repeat, meaning that the test is flaky, but not a blocker. We can wait with the fix to be merged in #55.

@plamut
plamut merged commit e2ddc2e into googleapis:masterApr 30, 2020
@plamut
plamut deleted the iss-88 branch April 30, 2020 07:55
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.type: cleanupAn internal cleanup or hygiene concern.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove test_utils directory

4 participants

@plamut@HemangChothani@googlebot@yoshi-kokoro