Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: remove py.typed since package fails mypy check - #988

Merged
tswast merged 1 commit into
mainfrom
revert-976-py-typed
Sep 27, 2021
Merged

fix: remove py.typed since package fails mypy check#988
tswast merged 1 commit into
mainfrom
revert-976-py-typed

Conversation

@tswast

Copy link
Copy Markdown
Contributor

@tswast
tswast requested review from a team and stephaniewang526September 27, 2021 18:39
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 27, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2021
@tswasttswast mentioned this pull request Sep 27, 2021
@tswasttswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 27, 2021
@tswast

Copy link
Copy Markdown
ContributorAuthor

Will check the library with mypy before reverting.

@tswasttswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 27, 2021
@tswast
tswast merged commit 39030f2 into mainSep 27, 2021
@tswast
tswast deleted the revert-976-py-typed branch September 27, 2021 19:01
gcf-merge-on-greenBot pushed a commit that referenced this pull request Sep 27, 2021
@plamut

Copy link
Copy Markdown
Contributor

Do we know what exactly caused that error? Is it an issue with some of our annotations, or does mypy behave differently from pytype?

It would be good to fix this while still retaining py.typed, although removing it as a short term fix to unblock maintainers of other is fine.

abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast@plamut@dandhlee