Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: add 'Instance.create_time' field - #449

Merged
tseaver merged 2 commits into
mainfrom
owl-bot-9e55390c-c8bd-42a3-8377-e665e862ce81
Oct 21, 2021
Merged

feat: add 'Instance.create_time' field#449
tseaver merged 2 commits into
mainfrom
owl-bot-9e55390c-c8bd-42a3-8377-e665e862ce81

Conversation

@gcf-owl-bot

@gcf-owl-botgcf-owl-botBot commented Oct 19, 2021•
edited by tseaver
Loading

Copy link
Copy Markdown
Contributor
  • Regenerate this pull request now.

Committer: @gdcolella
PiperOrigin-RevId: 404267819

Source-Link: googleapis/googleapis@324f036

Source-Link: https://github.com/googleapis/googleapis-gen/commit/2fada43b275eaaadd279838baf1120bddcffc762
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZhZGE0M2IyNzVlYWFhZGQyNzk4MzhiYWYxMTIwYmRkY2ZmYzc2MiJ9

@gcf-owl-bot
gcf-owl-botBot requested review from a teamOctober 19, 2021 16:48
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 19, 2021
@product-auto-labelproduct-auto-labelBot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Oct 19, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 19, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 19, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 19, 2021
@tseavertseaver changed the title feat: Add create_time to Instancefeat: add 'Instance.create_time' fieldOct 19, 2021
@tseaver

tseaver commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

Note: we are going to want to surface the create_time field as a read-only property in google.cloud.bigtable.instance.Instance.

@tseavertseaver added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 19, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2021
@tseaver

tseaver commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

Samples - Python 3.9 and Samples - Python 3.10 jobs are expected failures (we don't have them configured yet in samples/*/noxfile.py).

@tseaver

tseaver commented Oct 19, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

New flaky systests reported:

Old flaky sample reports reopened:

@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2021
tseaver added a commit that referenced this pull request Oct 20, 2021
@tseaver
feat: expose read-only 'Instance.create_time' property
0300121
From new field in the 'Instance' proto, added in PR #449.
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 20, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 20, 2021
@google-cla

google-claBot commented Oct 20, 2021

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-clagoogle-claBot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 20, 2021
@tseaver

tseaver commented Oct 20, 2021

Copy link
Copy Markdown
Contributor

@googlebot I consent.

@google-clagoogle-claBot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 20, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2021
@gcf-owl-bot

gcf-owl-botBot commented Oct 21, 2021

Copy link
Copy Markdown
ContributorAuthor

Owl bot is regenerating pull request 449...
Build name: NWUzYmIwYjAtZDc0My00MDg4LTg0YzgtMzYwNmQxOTVlNWFl

@gcf-owl-bot
feat: Add create_time to Instance
1329822
Committer: @gdcolella
PiperOrigin-RevId: 404267819
Source-Link: googleapis/googleapis@324f036
Source-Link: googleapis/googleapis-gen@2fada43
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZhZGE0M2IyNzVlYWFhZGQyNzk4MzhiYWYxMTIwYmRkY2ZmYzc2MiJ9
@gcf-owl-bot
gcf-owl-botBotforce-pushed the owl-bot-9e55390c-c8bd-42a3-8377-e665e862ce81 branch from 178da18 to 1329822CompareOctober 21, 2021 15:45
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 21, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 21, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 21, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 21, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 21, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 21, 2021
@tseaver
tseaver merged commit b9ecfa9 into mainOct 21, 2021
@tseaver
tseaver deleted the owl-bot-9e55390c-c8bd-42a3-8377-e665e862ce81 branch October 21, 2021 18:56
tseaver added a commit that referenced this pull request Oct 21, 2021
@tseaver
feat: expose read-only 'Instance.create_time' property
d835edf
From new field in the 'Instance' proto, added in PR #449.
@tseavertseaver mentioned this pull request Oct 21, 2021
Closed
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@tseavertseavertseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtableIssues related to the googleapis/python-bigtable API.cla: yesThis human has signed the Contributor License Agreement.owl-bot-copy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tseaver@yoshi-kokoro