Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: expose read-only 'Instance.create_time' property - #455

Closed
tseaver wants to merge 5 commits into
mainfrom
449-surface-instance-create_time
Closed

feat: expose read-only 'Instance.create_time' property#455
tseaver wants to merge 5 commits into
mainfrom
449-surface-instance-create_time

Conversation

@tseaver

@tseavertseaver commented Oct 21, 2021

Copy link
Copy Markdown
Contributor

From new field in the 'Instance' proto, added in PR #449.

@tseaver
feat: expose read-only 'Instance.create_time' property
d835edf
From new field in the 'Instance' proto, added in PR #449.
@tseaver
tseaver requested review from a team, crwilcox and kolea2October 21, 2021 18:57
@product-auto-labelproduct-auto-labelBot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Oct 21, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2021
@tseavertseaver mentioned this pull request Oct 21, 2021
Closed
chrisrossi
chrisrossi approved these changes Oct 25, 2021
View reviewed changes

@chrisrossichrisrossi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver
tseaverforce-pushed the 449-surface-instance-create_time branch from 08b37a8 to ff8d74eCompareOctober 25, 2021 14:58
@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2021
@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2021
@tseaver

tseaver commented Oct 27, 2021

Copy link
Copy Markdown
ContributorAuthor

Blocked on PR #465.

@tseavertseaver added the status: blocked Resolving the issue is dependent on other work. label Oct 27, 2021
@kolea2kolea2 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2021
kolea2
kolea2 suggested changes Oct 27, 2021
View reviewed changes

@kolea2kolea2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Please hold off on merging for now, need to confirm implementation across languages.

@tseaver

tseaver commented Nov 15, 2021

Copy link
Copy Markdown
ContributorAuthor

@kolea2

Thanks for this! Please hold off on merging for now, need to confirm implementation across languages.

OK. I've merged with main and fixed up the somewhat tricky conflicts (all in tests).

@partheaparthea assigned kolea2 and unassigned meredithslotaJan 12, 2022
@Mariatta

Mariatta commented Nov 18, 2022

Copy link
Copy Markdown
Contributor

Closing as this is not planned work.

@Mariatta

Mariatta commented Nov 18, 2022

Copy link
Copy Markdown
Contributor

We can reopen if it's needed.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crwilcoxcrwilcoxAwaiting requested review from crwilcox
2 more reviewers
@kolea2kolea2kolea2 requested changes
@chrisrossichrisrossichrisrossi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kolea2kolea2

Labels

api: bigtableIssues related to the googleapis/python-bigtable API.cla: yesThis human has signed the Contributor License Agreement.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.status: blockedResolving the issue is dependent on other work.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tseaver@Mariatta@chrisrossi@kolea2@meredithslota@yoshi-kokoro@parthea