Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 1, 2026. It is now read-only.
chore: add docfx session to noxfile, normalize - #100
Merged
Conversation
tmatsuo
commented
Aug 5, 2020
Contributor
@tseaver Thanks, I think we should also run synthtool to have other changes, in order to see if the test is actually passing. |
tseaver
commented
Aug 5, 2020
ContributorAuthor
@tmatsuo I lost my synthtool-fu during my hiatus. Can I just get my local copy updated to current |
tmatsuo
commented
Aug 5, 2020
Contributor
@tseaver Maybe I can add a commit to the branch. For the record, I was told there is a dependency on bazel. |
tmatsuo
commented
Aug 5, 2020
Contributor
I think you rebased, that should work too. Thanks! |
tseaver
commented
Aug 5, 2020
ContributorAuthor
tmatsuo
commented
Aug 5, 2020
Contributor
The docs-presubmit is passing :) Do you know why the samples are failing? |
tmatsuo
commented
Aug 5, 2020
Contributor
At a glance, the test has sth like |
tseaver
commented
Aug 5, 2020
ContributorAuthor
@tmatsuo We are hitting quota issues, breaking snippets / systests / samples. |
tmatsuo
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbreaking the
docs-presubmitbuild.