Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 1, 2026. It is now read-only.
chore: remove custom routing metadata - #1036
Merged
Merged
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
daniel-sanche
marked this pull request as ready for review
November 7, 2024 23:20
cindy-peng
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were manually constructing routing metadata headers for each rpc call, using
_make_metadata. This is no longer needed, due to a fix in the gapic_generator (googleapis/gapic-generator-python#2133)We can also remove some gapic customizations we added to prevent dulicate headers (closes#1004)
Currently blocked until #1026 is merged