Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

chore: use templated noxfile.py - #325

Closed
parthea wants to merge 4 commits into
masterfrom
use-templated-noxfile
Closed

chore: use templated noxfile.py#325
parthea wants to merge 4 commits into
masterfrom
use-templated-noxfile

Conversation

@parthea

@partheaparthea commented Jun 16, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Please review PR #326 before this one.

Fixes#324 🦕

@parthea
parthea requested review from a teamJune 16, 2021 11:22
@product-auto-labelproduct-auto-labelBot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jun 16, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2021
@parthea
partheaforce-pushed the use-templated-noxfile branch from 244688d to 1e48c89CompareJune 16, 2021 11:23
@partheaparthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
busunkim96
busunkim96 reviewed Jun 16, 2021
View reviewed changes
Comment threadowlbot.py
Comment threadowlbot.py
@partheaparthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2021
@parthea

parthea commented Jun 18, 2021

Copy link
Copy Markdown
ContributorAuthor

This is ready for review

@tseaver

tseaver commented Jun 21, 2021

Copy link
Copy Markdown
Contributor

@parthea, @kolea2 the failing samples look flaky to me: adding a cluster to a new instance is inherently tricksy, and needs more retry magyk fairy dust sprinkled on.

@tseaver

tseaver commented Jun 25, 2021

Copy link
Copy Markdown
Contributor

Superseded by #344.

@tseavertseaver closed this Jun 25, 2021
@tseaver
tseaver deleted the use-templated-noxfile branch June 25, 2021 21:03
tseaver added a commit that referenced this pull request Jul 9, 2021
@tseaver
chore: use templated 'noxfile.py'
26ef7cf
Extracted from PR #325.
tseaver added a commit that referenced this pull request Jul 9, 2021
@tseaver
chore: use templated 'noxfile.py'
383497d
Extracted from PR #325.
Closes#324.
@tseavertseaver mentioned this pull request Jul 9, 2021
Merged
tseaver added a commit that referenced this pull request Jul 9, 2021
@tseaver
chore: use templated 'noxfile.py'
738c722
Extracted from PR #325.
Closes#324.
tseaver added a commit that referenced this pull request Jul 9, 2021
@tseaver
chore: use templated 'noxfile.py'
4bdff1b
Extracted from PR #325.
Closes#324.
tseaver added a commit that referenced this pull request Jul 9, 2021
@tseaver
chore: use templated 'noxfile.py'
398fd27
Extracted from PR #325.
Closes#324.
tseaver added a commit that referenced this pull request Jul 12, 2021
@tseaver
chore: use templated 'noxfile.py' (#355)
2ee65b7
Extracted from PR #325.
Closes#324.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@busunkim96busunkim96busunkim96 left review comments
@tseavertseavertseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtableIssues related to the googleapis/python-bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Noxfile is not updated with Sphinx version pin

4 participants

@parthea@tseaver@busunkim96@yoshi-kokoro