Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

doc(samples): use operation to ensure creation completed - #356

Merged
tseaver merged 3 commits into
masterfrom
353-samples-harden-instance-cluster-crud
Jul 9, 2021
Merged

doc(samples): use operation to ensure creation completed#356
tseaver merged 3 commits into
masterfrom
353-samples-harden-instance-cluster-crud

Conversation

@tseaver

@tseavertseaver commented Jul 9, 2021

Copy link
Copy Markdown
Contributor

In addition to showing the better practice (using the operation returned
from 'Instance.create' / 'Cluster.create'), this change also hardens
the sample against eventual-consistency issues.

Closes#353.

@tseaver
doc(samples): use operation to ensure creation completed
4d6be5c
In addition to showing the better practice (using the operation returned
from 'Instance.create' / 'Cluster.create'), this change also hardens
the sample against eventual-consistency issues.
The timeouts used match those used in the system tests.
Closes#353.
@tseaver
tseaver requested a review from a teamJuly 9, 2021 15:28
@product-auto-labelproduct-auto-labelBot added api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. labels Jul 9, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2021
@tseavertseaver mentioned this pull request Jul 9, 2021
Merged
kolea2
kolea2 approved these changes Jul 9, 2021
View reviewed changes

@kolea2kolea2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after typo fix. Thanks for taking a look at this!

Comment threadsamples/instanceadmin/instanceadmin.py Outdated
Comment threadsamples/instanceadmin/instanceadmin.py Outdated
@tseavertseaver added the automerge Merge the pull request once unit tests and other checks pass. label Jul 9, 2021
@kolea2kolea2 removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 9, 2021
@kolea2

kolea2 commented Jul 9, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

@tseaver looks like the samples failed, maybe some unrelated flakiness?

edit: nvm, maybe we should increase the timeouts?

concurrent.futures._base.TimeoutError: Operation did not complete within the designated timeout.

@tseaver
tseaver merged commit aa5b606 into masterJul 9, 2021
@tseaver
tseaver deleted the 353-samples-harden-instance-cluster-crud branch July 9, 2021 18:39
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kolea2kolea2kolea2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtableIssues related to the googleapis/python-bigtable API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

samples.instanceadmin.test_instanceadmin: test_add_and_delete_cluster failed

2 participants

@tseaver@kolea2